Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Make API more PSR-compatible #44

Merged
merged 13 commits into from
Sep 2, 2017
Merged

Make API more PSR-compatible #44

merged 13 commits into from
Sep 2, 2017

Conversation

pinepain
Copy link
Member

@pinepain pinepain commented Sep 2, 2017

This is a set of major changes to make extension API more PSR-2 compatible.

@pinepain
Add typehint for $value param in Template::set(), closes #36
25f6c8f
@pinepain
Fix namespace mentioning v8=>V8 [skip ci]
de094ec
@pinepain
Rename constants to match PSR-2 convention, closes #34
9d99e7a
@pinepain
Make enum classes with constants finall, closes #39
b62b02f
@pinepain
Rename HeapStatistics methods to match PSR-2, closes #38
cad9598
@pinepain
Rename tests to remove V8 from file names
40a1531
@pinepain
[internals] Rename ScriptOrigin::{scriptID => scriptId}()
cd3bc4b
@pinepain
Add test to track all changes in extension entities
ac67c7b
@pinepain
Rename V8\Exception class and it methods, closes #33
2a06480
@pinepain
Alter tests to verify methods return type in advance to params type
7828d6f
@pinepain
Add missed return types hint
241d0f1
@pinepain
Add FunctionObject::getScriptId() method
6e48845
@pinepain
Fix segfault on shutdown during value self-cleanup
a968c64 
It happens when value tries to clenup itself but isolate was already destroyed
@pinepain pinepain added this to the 0.2.0 milestone Sep 2, 2017
@pinepain pinepain merged commit 67fa362 into master Sep 2, 2017
@pinepain pinepain deleted the refactoring branch September 2, 2017 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bc-breaking enhancement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@pinepain